mx unittest problem?

[Gilles Duboscq]

OK, interesting.
Thanks for figuring it out.
I'll see if we can fix that out at least make the error more user friendly

-Gilles
On 18 Apr 2014 22:11, "Eric Caspole" <Eric.Caspole at amd.com> wrote:

> I finally figured it out, the problem happened because the new file I
> added had CRLF line endings, (I don't know why since all my work is on
> Ubuntu lately), and the python regex in
> find_classes_with_matching_source_line() in mx.py does not seem to handle
> that.
>
> When I fixed the file back to "unix" style it worked.
> Eric
>
> ________________________________________
> From: gilwooden at gmail.com [gilwooden at gmail.com] on behalf of Gilles
> Duboscq [duboscq at ssw.jku.at]
> Sent: Friday, April 18, 2014 10:43 AM
> To: Caspole, Eric
> Cc: graal-dev at openjdk.java.net
> Subject: Re: mx unittest problem?
>
> Works for me:
>
> mx --vm server --vmbuild fastdebug unittest amd64.test
> executing junit tests now... (3 test classes)
> JUnit version 4.11
> ..I.Loaded disassembler from
>
> /home/gd/Dev/Graal/basic-graal/jdk1.8.0/fastdebug/jre/lib/amd64/hsdis-amd64.so
> ..III
> Time: 0.333
>
> OK (5 tests)
>
> I guess it has to do with some test you have that i don't. looks like
> it's a test that doesn't declare a package name.
>
> -Gilles
>
> On Fri, Apr 18, 2014 at 4:36 PM, Eric Caspole <Eric.Caspole at amd.com>
> wrote:
> > Is something wrong with mx? I think this used to work to run tests using
> the trailing part of the package name like hsail.test or amd64.test.
> >
> > This is this morning's openjdk tip.
> > Thanks,
> > Eric
> >
> >
> >
> > ecaspole at ecaspole-desktop:~/views/graal2/graal [10:26:07]$ ./mx.sh --vm
> server --vmbuild product unittest amd64.test
> > Traceback (most recent call last):
> >   File "/home/ecaspole/views/graal2/graal/mxtool/mx.py", line 4592, in
> <module>
> >     main()
> >   File "/home/ecaspole/views/graal2/graal/mxtool/mx.py", line 4573, in
> main
> >     retcode = c(command_args)
> >   File "/home/ecaspole/views/graal2/graal/mx/mx_graal.py", line 986, in
> unittest
> >     _unittest(args, annotations, whitelist=whitelist)
> >   File "/home/ecaspole/views/graal2/graal/mx/mx_graal.py", line 900, in
> _unittest
> >     _run_tests(args, harness, annotations, testfile, whitelist)
> >   File "/home/ecaspole/views/graal2/graal/mx/mx_graal.py", line 843, in
> _run_tests
> >     for c in _find_classes_with_annotations(p, None, annotations).keys():
> >   File "/home/ecaspole/views/graal2/graal/mx/mx_graal.py", line 803, in
> _find_classes_with_annotations
> >     return p.find_classes_with_matching_source_line(pkgRoot, matches,
> includeInnerClasses)
> >   File "/home/ecaspole/views/graal2/graal/mxtool/mx.py", line 259, in
> find_classes_with_matching_source_line
> >     assert pkg is not None
> > AssertionError
> >
>