small webrev to fix bug in hsail kernel argument logic

Christian Thalinger christian.thalinger at oracle.com
Wed Feb 5 19:53:37 PST 2014


The change looks good but in general this looks fragile:

  93 void HSAILKernelArguments::do_int() {
  94   // The last int is the iteration variable in an IntStream, but we don't pass it
  95   // since we use the HSAIL workitemid in place of that int value
  96   if (isLastParameter()) {
  97     if (TraceGPUInteraction) {
  98       tty->print_cr("[HSAIL] HSAILKernelArguments::not pushing trailing int");
  99     }
 100     return;
 101   }

On Feb 5, 2014, at 12:35 PM, Deneau, Tom <tom.deneau at amd.com> wrote:

> Doug --
> 
> The small webrev
>   http://cr.openjdk.java.net/~tdeneau/graal-webrevs/webrev-kernarg-fixes/webrev/
> 
> fixes some problems in the HsailKernelArguments code that caused some crashes with
> certain kernel argument combinations (not any of the existing junit test cases).]
> 
> In addition added some new test cases that would have failed but now pass.
> 
> -- Tom



More information about the graal-dev mailing list