small webrev to fix bug in hsail kernel argument logic

Vitaly Davidovich vitalyd at gmail.com
Wed Feb 5 20:32:18 PST 2014


Hi Tom,

if (TraceGPUInteraction) {
  65       tty->print_cr("[HSAIL] sig:%s  args length=%d,
_parameter_count=%d", signature->as_C_string(), _length, _parameter_count);
  66     }

Does the signature->as_C_string() require a ResourceMark? This is existing
code and only runs under the tracing flag, but thought I'd point it out.

Thanks

Sent from my phone
On Feb 5, 2014 3:36 PM, "Deneau, Tom" <tom.deneau at amd.com> wrote:

> Doug --
>
> The small webrev
>
> http://cr.openjdk.java.net/~tdeneau/graal-webrevs/webrev-kernarg-fixes/webrev/
>
> fixes some problems in the HsailKernelArguments code that caused some
> crashes with
> certain kernel argument combinations (not any of the existing junit test
> cases).]
>
> In addition added some new test cases that would have failed but now pass.
>
> -- Tom
>


More information about the graal-dev mailing list