small webrev to fix bug in hsail kernel argument logic

[Deneau, Tom]

OK, I have placed an updated webrev at:

   http://cr.openjdk.java.net/~tdeneau/graal-webrevs/webrev-kernarg-fixes-v2/webrev/


*         This adds the ResourceMark recommended by Vitaly

*         I also took the opportunity to include a small change to explicitly specify the alignment we use for kernel arguments (this is required for correct behavior by the HSAIL spec, given the way our host side code sets up kernel arguments).   This didn't show up on the simulator but would show up on hardware.

*         Also added 4 more test cases which exercise the alignment issue.

-- Tom


From: Deneau, Tom
Sent: Thursday, February 06, 2014 6:21 AM
To: 'Vitaly Davidovich'
Cc: Doug Simon; graal-dev at openjdk.java.net
Subject: RE: small webrev to fix bug in hsail kernel argument logic

Vitaly --

OK, I see that pattern of using a ResourceMark inside a small if (tracing) block in graalEnv.cpp.
I will submit a revised version.

-- Tom

From: Vitaly Davidovich [mailto:vitalyd at gmail.com]
Sent: Wednesday, February 05, 2014 10:32 PM
To: Deneau, Tom
Cc: Doug Simon; graal-dev at openjdk.java.net
Subject: Re: small webrev to fix bug in hsail kernel argument logic


Hi Tom,

if (TraceGPUInteraction) {
  65       tty->print_cr("[HSAIL] sig:%s  args length=%d, _parameter_count=%d", signature->as_C_string(), _length, _parameter_count);
  66     }

Does the signature->as_C_string() require a ResourceMark? This is existing code and only runs under the tracing flag, but thought I'd point it out.

Thanks

Sent from my phone
On Feb 5, 2014 3:36 PM, "Deneau, Tom" <tom.deneau at amd.com<mailto:tom.deneau at amd.com>> wrote:
Doug --

The small webrev
   http://cr.openjdk.java.net/~tdeneau/graal-webrevs/webrev-kernarg-fixes/webrev/

fixes some problems in the HsailKernelArguments code that caused some crashes with
certain kernel argument combinations (not any of the existing junit test cases).]

In addition added some new test cases that would have failed but now pass.

-- Tom