build error: okra_library_name

[Doug Simon]

On Jan 30, 2014, at 4:14 PM, Deneau, Tom <tom.deneau at amd.com> wrote:

> Doug --
> 
> There is Okra support on windows but for a real hardware version,
> not the simulator, so it is not public yet.
> 
> So it would be good to leave the #ifdef WINDOWS in.

Ok, I’ll add it back.

-Doug

>> -----Original Message-----
>> From: graal-dev-bounces at openjdk.java.net [mailto:graal-dev-
>> bounces at openjdk.java.net] On Behalf Of Doug Simon
>> Sent: Thursday, January 30, 2014 6:10 AM
>> To: Michael Haupt
>> Cc: graal-dev at openjdk.java.net
>> Subject: Re: build error: okra_library_name
>> 
>> My fault - pushing fix now.
>> 
>> Okra[1] is currently only supported on Linux so I don't think the
>> _WINDOWS clause should be there. I'll remove it.
>> 
>> -Doug
>> 
>> [1] https://wiki.openjdk.java.net/display/Sumatra/The+HSAIL+Simulator
>> 
>> On Jan 30, 2014, at 10:53 AM, Michael Haupt <michael.haupt at oracle.com>
>> wrote:
>> 
>>> Hi,
>>> 
>>> this is on Mac OS X:
>>> 
>>> -----
>>> .../basic-graal/src/gpu/hsail/vm/gpu_hsail.cpp:148:19: error: array
>>> initializer must be an initializer list or string literal
>>> 
>>> static char const okra_library_name[] = NULL;
>>> -----
>>> 
>>> The place in question:
>>> 
>>> -----
>>> #if defined(LINUX)
>>> static const char okra_library_name[] = "libokra_x86_64.so"; #elif
>>> defined(_WINDOWS) static char const okra_library_name[] =
>>> "okra_x86_64.dll"; #else static char const okra_library_name[] = NULL;
>>> #endif
>>> -----
>>> 
>>> What would be the correct value of the library name for DARWIN? If
>>> there isn't supposed to be one (and I can't test this as I don't
>>> currently use GPU backends), the compiler is happy with replacing the
>>> problematic line with
>>> 
>>> -----
>>> static char const *okra_library_name = NULL;
>>> -----
>>> 
>>> Best,
>>> 
>>> Michael
>>> 
>>> --
>>> 
>>> 
>>> Dr. Michael Haupt | Principal Member of Technical Staff
>>> Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Labs Oracle
>>> Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam,
>> Germany
>>> 	Oracle is committed to developing practices and products that
>> help
>>> protect the environment
>>> 
>> 
> 
>