new webrev for HSAILHotSpotLIRGenerator small fixes

Doug Simon doug.simon at oracle.com
Mon Mar 24 13:43:09 UTC 2014


Looks good to me. Pushing the change through now…

On Mar 24, 2014, at 2:01 PM, Caspole, Eric <Eric.Caspole at amd.com> wrote:

> Hi Doug,
> I finally remembered to do this -
> 
> http://cr.openjdk.java.net/~ecaspole/hsail_lir_update/
> 
> Thanks,
> Eric
> 
> ________________________________________
> From: Doug Simon [doug.simon at oracle.com]
> Sent: Thursday, March 20, 2014 11:17 AM
> To: Caspole, Eric
> Cc: graal-dev at openjdk.java.net
> Subject: Re: new webrev for HSAILHotSpotLIRGenerator small fixes
> 
> Hi Eric,
> 
> Since submitting this patch, the Kind.NarrowOop value was removed[1]. Can you please generate a new webrev based on the tip.
> 
> -Doug
> 
> [1] http://hg.openjdk.java.net/graal/graal/rev/82e4fe6fa525
> 
> On Mar 19, 2014, at 1:54 PM, Caspole, Eric <Eric.Caspole at amd.com> wrote:
> 
>> Hi everybody,
>> I put a new webrev here -
>> 
>> http://cr.openjdk.java.net/~ecaspole/hsail_lir/webrev/
>> 
>> This fixes 2 issues I found while trying Clumatra: storing compressed constants was not implemented yet (thanks Tom D for this), and previously HSAILHotSpotLIRGenerator did not "implements HotSpotLIRGenerator" so some methods would fail to compile with ClassCastExceptions in the middle of compilation. I implemented dummy stubs for all that that throws NYI instead.
>> Regards,
>> Eric
>> 
> 
> 
> 



More information about the graal-dev mailing list