Lowerable FloatRemNode

[Thomas Wuerthinger]

This change is fine. We can integrate it. - thomas

On 02 May 2014, at 00:06, D.Sturm <D.Sturm42 at gmail.com> wrote:

> To handle some edge cases for floating point remainder operation (pesky
> -0.0) I have to lower FloatRemNodes so I can write some snippets that
> handle the special cases.
> 
> Is there any problem with removing the final modifier on the class and
> making it implement Lowerable? Brings it in line with the Integer versions
> of those nodes and seems to be working fine for me.
> 
> The changes come down to changing the signature to
> 
> public class FloatRemNode extends FloatArithmeticNode implements
> Canonicalizable, Lowerable {
> 
> 
> and a boilerplate lowerable implementation:
> 
>    @Override    public void lower(LoweringTool tool) {
> tool.getLowerer().lower(this, tool);    }
> 
> 
> 
> -- Daniel