Proposal to reuse existing equality testing in unit tests

[Deneau, Tom]

Doug --

To make it work I had to extend GraalCompilerTest rather than GraalTest (new patch attached).
Otherwise it didn't do the deep equals for arrays.

But with that, this new patch works for me.  Thanks for noticing this duplication.

One question, I know we weren't really using it yet but we had made
an overrideable method that would determine whether two floats or two doubles were equal
so they wouldn't have to be exactly equal.

Is there any provision for that in your infrastructure?

-- Tom


> -----Original Message-----
> From: Doug Simon [mailto:doug.simon at oracle.com]
> Sent: Tuesday, May 13, 2014 10:34 AM
> To: Deneau, Tom
> Cc: graal-dev at openjdk.java.net
> Subject: Proposal to reuse existing equality testing in unit tests
> 
> Tom,
> 
> I noticed the special logic in KernelTester for comparing results of
> Okra based executions and sequential executions. As far as I can tell,
> this duplicates code that already exists in Graal and Junit. Could you
> please review this patch to remove the redundant logic:
> 
> http://cr.openjdk.java.net/~dnsimon/use-existing-equality-testing/
> 
> -Doug