@SlowPath renaming discussion

Laurent Daynes laurent.daynes at oracle.com
Fri Sep 26 15:12:57 UTC 2014


I agree with Gero. Don't use the word inlining -- it is way too overloaded.

Laurent

On 9/26/2014 5:09 PM, Gero Leinemann wrote:
>
> Though I find the simplicity of "@NotInlined" etc. appealing, I'd 
> recommend not to use the word "inline", as this is highly overloaded 
> in the Truffle/Graal context:
> 1. inlining by AST rewriting (language level)
> 2. inlining during/for PE (Truffle level)
> 3. inlining done by the compiler (Graal/compiler level)
> This confused - at least - me quite a bit when I started working at 
> FastR.
>
> What about @StopPE?
>
> Best,
> Gero
>
> Am 26.09.2014 um 16:49 schrieb Chris Seaton:
>> What about something less Truffle specific? What about @StopInlining, 
>> @NotInlined or @DontInline?
>>
>> On 26 Sep 2014, at 15:28, Michael Haupt <michael.haupt at oracle.com> 
>> wrote:
>>
>>> Hi Christian,
>>>
>>> Am 26.09.2014 um 16:11 schrieb Christian Humer 
>>> <christian.humer at gmail.com>:
>>> I would suggest these names:
>>> @Boundary
>>> @TruffleBoundary
>>> @PartialEvaluationBoundary (or @PEBoundary)
>>>
>>> Please add more suggestions and vote for whatever you think is best.
>>>
>>> I'll try to first give my rationale for how I try to come up with a 
>>> name. It should express the intent of the annotation with regard to 
>>> the method it is attached to, at a level that is understandable by a 
>>> Truffle user.
>>>
>>> Applying this, and note that this is purely my personal view, 
>>> @Boundary is a bit too fuzzy; @TruffleBoundary is more apt, but 
>>> regarding a method as a boundary is a bit odd; and @PEBoundary is 
>>> rather technical (not focused on the user).
>>>
>>> Alternative suggestions (more may be coming): @TruffleInterpreted, 
>>> @TruffleInterpretOnly. (Prepending "Truffle" should indicate that 
>>> the method is not exempt from compilation.)
>>>
>>> If the technical stance of @PartialEvaluationBoundary is agreeable 
>>> but the name is too long, how about @NoPE? ;-)
>>>
>>> Best,
>>>
>>> Michael
>>>
>>> -- 
>>>
>>>
>>> Dr. Michael Haupt | Principal Member of Technical Staff
>>> Phone: +49 331 200 7277 | Fax: +49 331 200 7561
>>> Oracle Labs
>>> Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 
>>> Potsdam, Germany
>>>     Oracle is committed to developing practices and products that 
>>> help protect the environment
>>>
>

-- 
Laurent Daynes
Oracle Labs



More information about the graal-dev mailing list