@SlowPath renaming discussion

Mario Wolczko mario.wolczko at oracle.com
Fri Sep 26 16:25:33 UTC 2014


Why not attempt to develop better inlining heuristics and do away with the annotation altogether?  I find it hard to believe this is not possible (although in some cases a judicious annotation may save a lot of computation).

> On Sep 26, 2014, at 8:28 AM, Chris Seaton <chris.seaton at oracle.com> wrote:
> 
> Ah - well how about @NotExpanded then?
> 
>> On 26 Sep 2014, at 16:24, Christian Humer <christian.humer at gmail.com> wrote:
>> 
>> I also agree not to use inline. I usually use "guest language inlining" for
>> 1), "expansion" for 2) and "host language inlining" for 3).
>> 
>> Will keep the suggestions flowing and will wrap up a vote later on.
>> 
>> 
>> 
>> - Christian Humer
>> 
>> On Fri, Sep 26, 2014 at 5:09 PM, Gero Leinemann <gero.leinemann at oracle.com>
>> wrote:
>> 
>>> 
>>> Though I find the simplicity of "@NotInlined" etc. appealing, I'd
>>> recommend not to use the word "inline", as this is highly overloaded in the
>>> Truffle/Graal context:
>>> 1. inlining by AST rewriting (language level)
>>> 2. inlining during/for PE (Truffle level)
>>> 3. inlining done by the compiler (Graal/compiler level)
>>> This confused - at least - me quite a bit when I started working at FastR.
>>> 
>>> What about @StopPE?
>>> 
>>> Best,
>>> Gero
>>> 
>>> Am 26.09.2014 um 16:49 schrieb Chris Seaton:
>>> 
>>> What about something less Truffle specific? What about @StopInlining,
>>>> @NotInlined or @DontInline?
>>>> 
>>>> On 26 Sep 2014, at 15:28, Michael Haupt <michael.haupt at oracle.com> wrote:
>>>> 
>>>> Hi Christian,
>>>>> 
>>>>> Am 26.09.2014 um 16:11 schrieb Christian Humer <
>>>>> christian.humer at gmail.com>:
>>>>> I would suggest these names:
>>>>> @Boundary
>>>>> @TruffleBoundary
>>>>> @PartialEvaluationBoundary (or @PEBoundary)
>>>>> 
>>>>> Please add more suggestions and vote for whatever you think is best.
>>>>> 
>>>>> I'll try to first give my rationale for how I try to come up with a
>>>>> name. It should express the intent of the annotation with regard to the
>>>>> method it is attached to, at a level that is understandable by a Truffle
>>>>> user.
>>>>> 
>>>>> Applying this, and note that this is purely my personal view, @Boundary
>>>>> is a bit too fuzzy; @TruffleBoundary is more apt, but regarding a method as
>>>>> a boundary is a bit odd; and @PEBoundary is rather technical (not focused
>>>>> on the user).
>>>>> 
>>>>> Alternative suggestions (more may be coming): @TruffleInterpreted,
>>>>> @TruffleInterpretOnly. (Prepending "Truffle" should indicate that the
>>>>> method is not exempt from compilation.)
>>>>> 
>>>>> If the technical stance of @PartialEvaluationBoundary is agreeable but
>>>>> the name is too long, how about @NoPE? ;-)
>>>>> 
>>>>> Best,
>>>>> 
>>>>> Michael
>>>>> 
>>>>> --
>>>>> 
>>>>> 
>>>>> Dr. Michael Haupt | Principal Member of Technical Staff
>>>>> Phone: +49 331 200 7277 | Fax: +49 331 200 7561
>>>>> Oracle Labs
>>>>> Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam,
>>>>> Germany
>>>>>       Oracle is committed to developing practices and products that
>>>>> help protect the environment
> 


More information about the graal-dev mailing list