JEP 243 changes

[Christian Wirth]

Hi Raffaello,

I also ran into the issue already. Python on Windows seems to behave 
differently in finding and patching the version string.

Doug and me are working on a fix already. Hope we can push it to the 
repository soon.

-- Christian



Am 29.05.2015 um 11:29 schrieb Raffaello Giulietti:
> After this change, on Win7 I cannot build graal anymore, not even from a
> freshly cloned copy of the repository.
>
>
> Traceback (most recent call last):
>    File "C:\dev\graal\/mxtool/mx.py", line 5685, in <module>
>      main()
>    File "C:\dev\graal\/mxtool/mx.py", line 5666, in main
>      retcode = c(command_args)
>    File "C:\dev\graal\mx\mx_graal.py", line 939, in build
>      jdk = _jdk(build, create=True, installJars=installJars)
>    File "C:\dev\graal\mx\mx_graal.py", line 487, in _jdk
>      _installDistInJdks(jdkDist)
>    File "C:\dev\graal\mx\mx_graal.py", line 696, in _installDistInJdks
>      _patchGraalVersionConstant(dist)
>    File "C:\dev\graal\mx\mx_graal.py", line 681, in
> _patchGraalVersionConstant
>      assert '@@graal.version@@' in data, 'could not find
> "@@graal.version@@" cons
> tant in ' + dist.path + '!' + zi.filename
> AssertionError: could not find "@@graal.version@@" constant in
> C:\dev\graal\buil
> d\graal.jar!com/oracle/graal/api/runtime/Graal.class
>
>
>
>
> On 2015-05-29 08:36, Doug Simon wrote:
>> I’ve just pushed changes related to https://bugs.openjdk.java.net/browse/GRAAL-53 which in turn are part of preparing Graal for JEP 243. These changes touched a lot of files and shuffled a number of packages/projects around. In particular, there’s a new com.oracle.jvmci namespace to which all the Graal code that will form the basis of JEP 243 has been moved. We will continue to refine the classes in this namespace (especially the API classes) to the absolute minimum required for implementing a Java based compile on the JVM.
>>
>> These steps should help mitigate issues when you pull these changes:
>>
>> 1. Delete all JDKs deployed in your Graal workspace (i.e. rm -rf jdk*)
>> 2. mx clean
>> 3. mx ideclean; mx ideinit
>>
>> -Doug
>