CR for RFR 63

Doug Simon doug.simon at oracle.com
Wed May 18 12:15:55 UTC 2016


Hi Michael,

Thanks for the submission. A quick glance indicates there should be no issue integrating this change.

Could you please re-submit it as a PR on https://github.com/graalvm/graal-core? The review support on github is better than email based reviewing of patches/webrevs.

-Doug

> On 18 May 2016, at 01:09, Berg, Michael C <michael.c.berg at intel.com> wrote:
> 
> Hi Folks,
> 
> I have added components that now handle front to back all assembler emit through a single channel, namely the AMD64Assembler object. All sub classes that extend AMD64RROp and emit SSE code now channel directly through AMD64Assembler object via formal encoding methods. These methods are currently up-propagate-able to AVX based on CPUID check generically for all SIMD emitted code. In this set is the ArrayEquals intrinsic which now has support for AVX with 256bit forms allowed and used there.  Please review and comment.
> 
> This code was tested as follows (see jbs entry below): mx unittest (no new failures), SpecJvm2008 (all suites pass : I run compress through xml.transform).  The code is also checkstyle compliant.
> 
> Bug-id: https://bugs.openjdk.java.net/browse/GRAAL-63
> 
> 
> 
> Git diff:
> https://bugs.openjdk.java.net/secure/attachment/59541/array_equals_plus_asm.diff
> 
> Thanks,
> Michael
> 



More information about the graal-dev mailing list