Problem with broken build (was Re: RFR: AArch64: Implementing address lowering to make use of immediate address mode

[Gilles Duboscq]

Hi Andrew,

mx supdate does not pull in any new changes, it just goes to tip/branch head in all repos.

mx sforceimports makes sure that all repos are at the version specified in the suite.py files, pull new changes in if necessary.

 Gilles

On 20/03/17 17:40, Andrew Dinn wrote:
> On 20/03/17 10:42, Thomas Wuerthinger wrote:
>> Make sure to be on the latest version. A few days ago the address
>> lowering phase was moved to be after the new fix reads phase. Means
>> no need to deal with pi nodes.
> 
> Well, that sounds like a good idea. However, I appear to be snookered
> because of an incompatibility introduced between graal and truffle (see
> log output after signature).
> 
> It seems that the following recent change to class GraalTVMCI () added
> methods cloneUninitialized and isCloneUninitializedSupported which
> indirect to super class TVMCI:
> 
>   commit 7d9581a3f0a82ff7d5e9a9eb03642d1eb12b0dc2
>   Author: Christian Humer <christian.humer at oracle.com>
>   Date:   Wed Feb 15 14:15:30 2017 +0100
> 
>       Use TMVCI to access isCloneUnitializedSupported and cloneUnitialized
> 
> 
> I have run 'mx supdate' but the source for class TVMCI in the truffle
> tree does not include these methods. Did someone forget to update the
> graal tree to specify a new truffle repo version dependency? Or am I
> supposed to do that by hand? e.g. by pulling the mos up to date truffle
> tree?
> 
> regards,
> 
> 
> Andrew Dinn
> -----------
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in England and Wales under Company Registration No. 03798903
> Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
> 
> ----- 8< -------- 8< -------- 8< -------- 8< -------- 8< -------- 8< ---
> 
> $ JVMCI_VERSION_CHECK=ignore mx --java-home
> ~/openjdk/jdk9/build/linux-aarch64-normal-server-release/images/jdk build
>   . . .
> Compiling org.graalvm.compiler.loop.test with javac-daemon...
> [dependency org.graalvm.compiler.loop updated]
> /home/adinn/openjdk/graal/graal-core/graal/org.graalvm.compiler.truffle/src/org/graalvm/compiler/truffle/GraalTVMCI.java:77:
> error: method does not override or implement a method from a supertype
>     @Override
>     ^
> /home/adinn/openjdk/graal/graal-core/graal/org.graalvm.compiler.truffle/src/org/graalvm/compiler/truffle/GraalTVMCI.java:79:
> error: cannot find symbol
>         return super.cloneUninitialized(root);
>                     ^
>   symbol: method cloneUninitialized(RootNode)
> /home/adinn/openjdk/graal/graal-core/graal/org.graalvm.compiler.truffle/src/org/graalvm/compiler/truffle/GraalTVMCI.java:82:
> error: method does not override or implement a method from a supertype
>     @Override
>     ^
> /home/adinn/openjdk/graal/graal-core/graal/org.graalvm.compiler.truffle/src/org/graalvm/compiler/truffle/GraalTVMCI.java:84:
> error: cannot find symbol
>         return super.isCloneUninitializedSupported(root);
>                     ^
>   symbol: method isCloneUninitializedSupported(RootNode)
>   . . .
> 4 errors
> Compiling org.graalvm.compiler.truffle with javac-daemon failed
> 1 build tasks failed
>