String.compareTo intrinsic for AArch64

Dmitry Samersoff dms at samersoff.net
Mon Apr 16 13:04:56 UTC 2018


Yudi, Doug,

I addressed all comments and the fix is ready to push.

Please, let me know if something is still on my side.

-Dmitry

On 19.03.2018 17:35, Yudi Zheng wrote:
> Hi Dmitry,
> 
> Thanks for the contribution (again)!
> 
> Recently we discover that the AMD64 String.compareTo intrinsic on Java 8
> might occasionally lead to HotSpot crashes. I have create a pull request
> https://github.com/oracle/graal/pull/315, and hopefully that would address
> the issue. Since I cannot assign you as the reviewer, could you please
> leave a comment there whether it is good to go? Once that gets in, the
> test cases will be enabled again.
> 
> GR-8748 is from our internal JIRA tracker.
> 
> Thanks,
> Yudi
> 
> 
>> On 19 Mar 2018, at 15:24, Dmitry Samersoff <dms at samersoff.net
>> <mailto:dms at samersoff.net>> wrote:
>>
>> Hi Everybody,
>>
>> I created a basic intrinsic for String.compareTo on AArch64
>>
>> https://github.com/oracle/graal/pull/319
>>
>> Any comments are much appreciated.
>>
>>
>> Q: Could someone explain to me how @Ignore("GR-8748") works?
>>
>> 1. Where is bugtracker with GR-8748?
>>
>> 2. It looks like this keyword prevent test execution for all platforms
>> and all jdk versions. Could we make it more precise?
>>
>> -Dmitry
>>
>> -- 
>> Dmitry Samersoff
>> http://devnull.samersoff.net
>> * There will come soft rains ...
>>
> 


-- 
Dmitry Samersoff
http://devnull.samersoff.net
* There will come soft rains ...



More information about the graal-dev mailing list