Adopt javah deprecation
Doug Simon
doug.simon at oracle.com
Sun Jan 14 10:45:35 UTC 2018
> On 14 Jan 2018, at 11:19, Dmitry Samersoff <dms at samersoff.net> wrote:
>
> Hi Doug,
>
> Thank you for your help. I'm a greenhorn graal contributor so not
> familiar with policies yet.
No problem. We'll will try to quickly bring you up to speed ;-)
>
> I created pull requests:
>
> https://github.com/graalvm/mx/pull/142
> https://github.com/oracle/graal/pull/283
>
> mx changes are safe and straightforward.
>
> But *graal changes has a big impact* to the process.
>
> 1. It tightly depends to mx changes and brakes the build if someone
> pushes it before mx changes.
>
> 2. We should notify graal users that they have to update mx.
Fr these kind of changes, one just bumps the mx version[1] required by Graal.
> 3. It's not clear to me how we should handle jdk8 that stay with javah
I've assigned the graal PR to Roland Schatz who is our expert on building Graal-based native projects.
>
> So any opinion is much appreciated.
>
> -Dmitry
[1] https://github.com/oracle/graal/blob/59827e13d88ad227306f65aa3d24f2ea8d98fc97/compiler/mx.compiler/suite.py#L2
>
>
> On 01/13/2018 11:22 PM, Doug Simon wrote:
>> Hi Dmitry,
>>
>> Could you please create pull requests at https://github.com/graalvm/mx and https://github.com/oracle/graal respectively to get these changes properly reviewed and integrated.
>>
>> Thanks!
>>
>> -Doug
>>
>>> On 13 Jan 2018, at 14:13, Dmitry Samersoff <dms at samersoff.net> wrote:
>>>
>>> Hi Everybody,
>>>
>>> javah deprecated since jdk8 and completely removed in jdk11. So we
>>> should replace javah with javac -h <directory> in graal/truffle build.
>>>
>>> Below is the patch I proposed:
>>>
>>> On MX side, always use javac -h .
>>>
>>> On Graal side change com.oracle.truffle.nfi.native/Makefile
>>> to collect generated headers on the fly.
>>>
>>>
>>> https://github.com/dsamersoff/mx/commit/f55ba964e46aadb494280274c521a6853bfaef0d
>>>
>>> https://github.com/dsamersoff/graal/commit/ed7ffedde748e5f10b241924ed0995f5916dbc4c
>>>
>>>
>>> -Dmitry
>>>
>>>
>>
>
>
>
>
More information about the graal-dev
mailing list