String.compareTo intrinsic for AArch64

Dmitry Samersoff dms at samersoff.net
Mon Mar 26 09:43:59 UTC 2018


Doug,

Do you have any updates on this AArch64 intrinsic?

Is anything required from my side to have it pushed?

-Dmitry

On 19.03.2018 17:34, Doug Simon wrote:
> 
> 
>> On 19 Mar 2018, at 15:24, Dmitry Samersoff <dms at samersoff.net> wrote:
>>
>> Hi Everybody,
>>
>> I created a basic intrinsic for String.compareTo on AArch64
>>
>> https://github.com/oracle/graal/pull/319
>>
>> Any comments are much appreciated.
>>
>>
>> Q: Could someone explain to me how @Ignore("GR-8748") works?
> 
> @Ignore is a junit annotation that prevents a test being run. The value of the annotation is only a comment and is not interpreted by junit.
> 
>> 1. Where is bugtracker with GR-8748?
> 
> This is an Oracle-internal jira instance. The bug it relates to is described at https://github.com/oracle/graal/pull/299#pullrequestreview-104037056.
> 
>> 2. It looks like this keyword prevent test execution for all platforms
>> and all jdk versions. Could we make it more precise?
> 
> You can replace the @Ignore on the test method with something like:
> 
>         Assume.assumeFalse(getTarget().arch instanceof AMD64);
> 
> Yudi: Is that what Dmitry should do while you're working on the fix for GR-8748?
> 
> -Doug
> 


-- 
Dmitry Samersoff
http://devnull.samersoff.net
* There will come soft rains ...



More information about the graal-dev mailing list