Please update Graal in OpenJDK

[Andrew Haley]

On 05/29/2018 01:27 PM, Doug Simon wrote:
> 
> 
>> On 29 May 2018, at 14:02, Andrew Haley <aph at redhat.com> wrote:
>>
>> On 05/26/2018 10:03 AM, Andrew Haley wrote:
>>> On 05/26/2018 09:41 AM, Doug Simon wrote:
>>>> I've added a patch to https://bugs.openjdk.java.net/browse/JDK-8202670 that needs to be applied after running `mx updategraalinopenjdk`.
>>>
>>> OK, I'll try that,  Thanks.
>>>
>>
>> Still a few problems:
>>
>> Creating symlink jdk/lib/ct.sym
>> /local/jdk-jdk/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.jdk9.test/src/org/graalvm/compiler/replacements/jdk9/UnsafeReplacementsTest.java:28: error: package org.graalvm.compiler.api.test does not exist
>> import org.graalvm.compiler.api.test.Graal;
>>                                    ^
>> /local/jdk-jdk/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.jdk9.test/src/org/graalvm/compiler/replacements/jdk9/UnsafeReplacementsTest.java:29: error: package org.graalvm.compiler.replacements.test does not exist
>> import org.graalvm.compiler.replacements.test.MethodSubstitutionTest;
>>                                             ^
>> ...
>>
>> Did this work for you?
> 
> Looks like the patch didn't apply cleanly as it excludes org.graalvm.compiler.replacements.test.jdk9:
> 
> diff -r f84ae8aa5d88 make/CompileJavaModules.gmk 
> --- a/make/CompileJavaModules.gmk	Sat May 26 03:11:50 2018 -0400 
> +++ b/make/CompileJavaModules.gmk	Sat May 26 10:36:35 2018 +0200 
> @@ -440,11 +440,13 @@ 
>   
>  jdk.internal.vm.compiler_EXCLUDES += \ 
>      jdk.internal.vm.compiler.collections.test \ 
> + org.graalvm.compiler.processor \ 
>      org.graalvm.compiler.core.match.processor \ 
>      org.graalvm.compiler.nodeinfo.processor \ 
>      org.graalvm.compiler.options.processor \ 
>      org.graalvm.compiler.serviceprovider.processor \ 
> - org.graalvm.compiler.replacements.verifier \ 
> + org.graalvm.compiler.replacements.processor \ 
> + org.graalvm.compiler.replacements.test.jdk9 \ 
>      org.graalvm.compiler.api.directives.test \ 
>      org.graalvm.compiler.api.test \ 
>      org.graalvm.compiler.asm.aarch64.test \ 

This is what the file looks like after I patched it:

jdk.internal.vm.compiler_EXCLUDES += \
    jdk.internal.vm.compiler.collections.test \
 org.graalvm.compiler.processor \
    org.graalvm.compiler.core.match.processor \
    org.graalvm.compiler.nodeinfo.processor \
    org.graalvm.compiler.options.processor \
    org.graalvm.compiler.serviceprovider.processor \
 org.graalvm.compiler.replacements.processor \
 org.graalvm.compiler.replacements.test.jdk9 \
    org.graalvm.compiler.api.directives.test \
 ...

so that patch definitely worked.

But the package is called org.graalvm.compiler.replacements.jdk9.test, not
org.graalvm.compiler.replacements.test.jdk9

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671