[13] RFR(L) 8220623: [JVMCI] Update JVMCI to support JVMCI based Compiler compiled into shared library

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Apr 4 23:45:46 UTC 2019

Thank you, Kim

I moved HotSpotJVMCI methods which call JNIHandles::resolve() to jvmciJavaClasses.cpp file so that I don't need to 
include jniHandles.inline.hpp into .hpp file.

I will update changes when I address your other comments.


On 4/4/19 1:57 PM, Kim Barrett wrote:
>> On Apr 4, 2019, at 3:22 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>> New delta:
>> http://cr.openjdk.java.net/~kvn/8220623/webrev_delta.06/
>> Full:
>> http://cr.openjdk.java.net/~kvn/8220623/webrev.06/
>> New changes are based on Kim and Stefan suggestions:
>> - Moved JVMCI::oops_do() from JNIHandles to places where it should be called.
>> - Moved JVMCI cleanup task to the beginning of ParallelCleaningTask::work().
>> - Used JVMCI_ONLY macro with COMMA.
>> - Disable JVMCI build on SPARC. We don't use it - neither Graal or AOT are built on SPARC. Disabling also helps to find missing JVMCI guards.
>> I ran hs-tier1-3 testing - it passed (hs-tier3 includes graal testing).
>> I started hs-tier4..8-graal testing.
>> I will do performance testing next.
> ------------------------------------------------------------------------------
> src/hotspot/share/jvmci/jvmciJavaClasses.hpp
>    28 #include "runtime/jniHandles.inline.hpp"
> .hpp files are not permitted to #include .inline.hpp files.
> We've fixed most violations (I think there are still a few lingering
> ones that have not yet been disentangled); please don't add new ones.
> ------------------------------------------------------------------------------

More information about the graal-dev mailing list