From aph at redhat.com Mon May 11 09:19:33 2020 From: aph at redhat.com (Andrew Haley) Date: Mon, 11 May 2020 10:19:33 +0100 Subject: [aarch64-port-dev ] RFR: 8244164: AArch64: jaotc generates incorrect code for compressed OOPs with non-zero heap base In-Reply-To: <858shy9a6w.fsf@arm.com> References: <858shy9a6w.fsf@arm.com> Message-ID: <9ad52446-7779-1fe2-db26-2640f4da5b97@redhat.com> On 5/11/20 8:56 AM, Nick Gasson wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8244164 > Webrev: http://cr.openjdk.java.net/~ngasson/8244164/webrev.0/ > > On AArch64 if the VM jaotc is running in uses compressed oops with a > zero base it will not emit instructions to add/subtract the heap base > when compressing/decompressing oops. This causes a crash if the AOT'd > shared library is loaded into a VM with non-zero heap base. > > Tested jtreg hotspot_all_no_apps, jdk_core with no new failures. OK. > I've made a separate pull request for Graal [1] but I'm submitting this > here too as I want to backport to 14 and 11u and also add a jtreg > test. Not sure if this is the right process to follow? > > [1] https://github.com/oracle/graal/pull/2446 Sure. It's good to get input from both sides. -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671