RFR: 8313302: Fix formatting errors on Windows [v3]

Kim Barrett kbarrett at openjdk.org
Tue Aug 1 13:19:53 UTC 2023


On Fri, 28 Jul 2023 07:50:19 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Fix several formatting errors on Windows
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   zPhysicalMemoryBacking_windows.cpp

Most/all of the PTR_FORMAT => INTPTR_FORMAT changes should not be made.
Especially those where the argument is the result of a call to p2i.
The p2i thing plus the definition of PTR_FORMAT are a bit of a kludge
to work around the variations in the implementations of "%p", which is
what one might wish PTR_FORMAT was using.

I've not looked at the rest yet.  It would be easier to do so once the
PTR_FORMAT => INTPTR_FORMAT changes were removed.

-------------

Changes requested by kbarrett (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15063#pullrequestreview-1556982044


More information about the graal-dev mailing list