RFR: 8313564: Fix -Wconversion warnings in classfile code [v4]

Coleen Phillimore coleenp at openjdk.org
Thu Aug 3 12:01:35 UTC 2023


On Thu, 3 Aug 2023 06:37:34 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix Atomic items_added code.
>
> src/hotspot/share/classfile/stringTable.cpp line 804:
> 
>> 802: void StringTable::allocate_shared_strings_array(TRAPS) {
>> 803:   assert(DumpSharedSpaces, "must be");
>> 804:   if (_items_count > max_jint) {
> 
> This is impossible given `_items_count_` is now an int

Maybe we still want items_count to be a size_t then so we can detect this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15111#discussion_r1283099990


More information about the graal-dev mailing list