RFR: 8313564: Fix -Wconversion warnings in classfile code [v5]

Coleen Phillimore coleenp at openjdk.org
Fri Aug 4 13:34:34 UTC 2023


On Fri, 4 Aug 2023 05:14:16 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert items_count change to int.  Add check for items_count overflow in SymbolTable.
>
> src/hotspot/share/classfile/stringTable.cpp line 805:
> 
>> 803:   assert(DumpSharedSpaces, "must be");
>> 804:   if (_items_count > (size_t)max_jint) {
>> 805:     fatal("Too many strings to be archived: " SIZE_FORMAT, _items_count);
> 
> An opportunity for `%zu`? :)

Ok, yes!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15111#discussion_r1284431061


More information about the graal-dev mailing list