RFR: 8308850: Change JVM options with small ranges from 64 to 32 bits, for globals.hpp

Coleen Phillimore coleenp at openjdk.org
Sat Aug 5 16:24:30 UTC 2023


On Fri, 4 Aug 2023 22:44:49 GMT, Dean Long <dlong at openjdk.org> wrote:

>> The JVM options that are in range of `int` type are converted in `globals.hpp` and other files where affected.
>> 
>> ### Tests
>> tiers 1-4 passed for linux-x64, linux-x64-debug, windows-x64, windows-x64-debug
>> tier1 all passed.
>
> src/hotspot/share/runtime/globals.hpp line 1590:
> 
>> 1588:           "switch")                                                         \
>> 1589:                                                                             \
>> 1590:   develop(int, StopInterpreterAt, 0,                                        \
> 
> Some cpu ports access this from assembly, so changing the size is gong to require cpu-specific changes.  I'd rather see this and BytecodeCounter::_counter_value both changed to uint64_t.

share/interpreter/bytecodeHistogram.cpp:int   BytecodeCounter::_counter_value = 0;

Maybe this should be inx instead.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15164#discussion_r1285083024


More information about the graal-dev mailing list