RFR: 8308850: Change JVM options with small ranges from 64 to 32 bits, for globals.hpp
David Holmes
dholmes at openjdk.org
Mon Aug 7 02:40:33 UTC 2023
On Fri, 4 Aug 2023 22:45:58 GMT, Dean Long <dlong at openjdk.org> wrote:
>> The JVM options that are in range of `int` type are converted in `globals.hpp` and other files where affected.
>>
>> ### Tests
>> tiers 1-4 passed for linux-x64, linux-x64-debug, windows-x64, windows-x64-debug
>> tier1 all passed.
>
> src/hotspot/share/opto/macro.cpp line 1841:
>
>> 1839: // Generate several prefetch instructions.
>> 1840: int step_size = AllocatePrefetchStepSize;
>> 1841: int distance = AllocatePrefetchDistance;
>
> I think this is a step in the wrong direction. Shouldn't these remain uint?
This change also doesn't fit the PR description. There is no need to change this in this PR (or even at all).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15164#discussion_r1285309136
More information about the graal-dev
mailing list