RFR: 8308850: Change JVM options with small ranges from 64 to 32 bits, for globals.hpp
Coleen Phillimore
coleenp at openjdk.org
Mon Aug 7 12:05:34 UTC 2023
On Mon, 7 Aug 2023 02:07:22 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> share/interpreter/bytecodeHistogram.cpp:int BytecodeCounter::_counter_value = 0;
>>
>> Maybe this should be inx instead.
>
> The only reason to use `intx` is if this should be 32-bit on 32-bit and 64-bit on 64-bit. I don't think that is the case here.
The reason that this should be reverted is that to fix it, you have to fix all the platform code and that seems out of scope for fixing Wconversion warnings.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15164#discussion_r1285771575
More information about the graal-dev
mailing list