RFR: 8308850: Change JVM options with small ranges from 64 to 32 bits, for globals.hpp [v2]

Coleen Phillimore coleenp at openjdk.org
Tue Aug 8 12:15:37 UTC 2023


On Tue, 8 Aug 2023 09:22:12 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> The JVM options that are in range of `int` type are converted in `globals.hpp` and other files where affected.
>> 
>> ### Tests
>> tiers 1-4 passed for linux-x64, linux-x64-debug, windows-x64, windows-x64-debug
>> tier1 all passed.
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments applied.

This looks good with the minor issue of removing a blank space.

src/hotspot/share/runtime/globals.hpp line 1590:

> 1588:           "switch")                                                         \
> 1589:                                                                             \
> 1590:   develop(intx, StopInterpreterAt, 0,                                        \

Does this add a blank?  Should be aligned.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15164#pullrequestreview-1567155588
PR Review Comment: https://git.openjdk.org/jdk/pull/15164#discussion_r1287028124


More information about the graal-dev mailing list