RFR: 8313372: [JVMCI] Export vmIntrinsics::is_intrinsic_available results to JVMCI compilers. [v2]
Dean Long
dlong at openjdk.org
Wed Aug 9 09:08:59 UTC 2023
On Thu, 3 Aug 2023 07:12:08 GMT, Yudi Zheng <yzheng at openjdk.org> wrote:
>> This PR exports `vmIntrinsic::is_intrinsic_available`, `Compiler::is_intrinsic_supported`, and `C2Compiler::is_intrinsic_supported` results to JVMCI compiler. This allows JVMCI compiler to comply with `-XX:DisableIntrinsic`, `-XX:ControlIntrinsic`, `-XX:-UseXXXIntrinsic`, and is essential for running test that depends on these flags, e.g., `java/lang/Float/Binary16ConversionNaN` that returns different result in the interpreter with `-XX:DisableIntrinsic=_float16ToFloat,_floatToFloat16`.
>> This PR also attempts to fix some of the `is_intrinsic_available` results. Please see the inlined comments.
>
> Yudi Zheng has updated the pull request incrementally with one additional commit since the last revision:
>
> update is_intrinsic_supported for _dcopySign,_fcopySign.
I don't having the same logic in two places, because then those two places need to be kept in sync. Either the stubs should be generated based on is_intrinsic_supported(), or is_intrinsic_supported() should check if the stub was generated.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15133#issuecomment-1670921720
More information about the graal-dev
mailing list