RFR: 8313882: Fix -Wconversion warnings in runtime code [v2]

Coleen Phillimore coleenp at openjdk.org
Wed Aug 9 14:18:29 UTC 2023


On Wed, 9 Aug 2023 13:06:54 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> I don't know how big these values are, but if they were large then uint64_t sum could overflow.
>
> uint64_t count = (uint64_t)method->compiled_invocation_count();
> 
> They seem to be a sum of compiled_invocation_count() so maybe double is best.

I reverted this to change sum and weighed_sum back to double, and add the cast back to histo.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15177#discussion_r1288516748


More information about the graal-dev mailing list