RFR: 8308850: Change JVM options with small ranges from 64 to 32 bits, for globals.hpp [v3]
Afshin Zafari
azafari at openjdk.org
Wed Aug 9 14:54:30 UTC 2023
On Wed, 9 Aug 2023 07:17:32 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>>
>> backslash aligned
>
> src/hotspot/share/runtime/globals.hpp line 1311:
>
>> 1309: "Hit breakpoint when mallocing/freeing this pointer") \
>> 1310: \
>> 1311: develop(int, StackPrintLimit, 100, \
>
> You can remove this cast now:
>
> ./share/utilities/vmError.cpp: const int limit = max_frames == -1 ? StackPrintLimit : MIN2(max_frames, (int)StackPrintLimit);
Fixed.
> src/hotspot/share/runtime/globals.hpp line 1748:
>
>> 1746: "Data sampling interval (in milliseconds)") \
>> 1747: range(PeriodicTask::min_interval, max_jint) \
>> 1748: constraint(PerfDataSamplingIntervalFunc, AfterErgo) \
>
> You need to change the type of the `PerfDataSamplingIntervalFunc` as well.
I changed this and checked for the other options I changed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15164#discussion_r1288598106
PR Review Comment: https://git.openjdk.org/jdk/pull/15164#discussion_r1288601635
More information about the graal-dev
mailing list