RFR: 8313882: Fix -Wconversion warnings in runtime code [v2]

Coleen Phillimore coleenp at openjdk.org
Wed Aug 9 16:52:59 UTC 2023


On Wed, 9 Aug 2023 13:49:20 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/runtime/arguments.cpp line 1215:
>> 
>>> 1213:       }
>>> 1214:     }
>>> 1215:     c = getc(stream);
>> 
>> How about int c0 for the getc value, then the first line in the loop does
>> char c = checked_cast<char>(c0);
>> No other changes should be needed.
>
> There was a reason that c had to be an int.  Now I'll have to rebuild and figure it out again.

No, it works and is a bit better, so I made this change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15177#discussion_r1288883114


More information about the graal-dev mailing list