RFR: 8313882: Fix -Wconversion warnings in runtime code [v8]
David Holmes
dholmes at openjdk.org
Thu Aug 10 07:18:07 UTC 2023
On Thu, 10 Aug 2023 01:26:00 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Here are fixes to silence -Wconversion warnings in runtime code. Use direct cast for 64 bit int to double, otherwise default to checked_cast<>. I changed the declaration of _held_monitor_count and _jni_monitor count to intx to fix cascade of warnings coming from this.
>>
>> src/hotspot/share/runtime/synchronizer.cpp:1802:41: warning: conversion from 'intx' {aka 'long int'} to 'int' may change value [-Wconversion]
>> 1802 | _thread->dec_held_monitor_count(rec + 1);
>> | ~~~~^~~
>>
>> Tested with tier1-4 on linux-x64-debug and windows-x64-debug and tier1 on Oracle supported platforms.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>
> Add a checked_cast.
Overall seems okay. A couple of minor comments.
Thanks.
Clicked wrong button :)
-------------
PR Review: https://git.openjdk.org/jdk/pull/15177#pullrequestreview-1571161170
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15177#pullrequestreview-1571163699
More information about the graal-dev
mailing list