RFR: 8313372: [JVMCI] Export vmIntrinsics::is_intrinsic_available results to JVMCI compilers. [v5]
Yudi Zheng
yzheng at openjdk.org
Fri Aug 11 15:22:58 UTC 2023
On Thu, 10 Aug 2023 17:00:30 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> https://bugs.openjdk.org/browse/JDK-8181616 added support_avx() check because new Fma vectorization needs AVX: https://cr.openjdk.org/~vdeshpande/8181616/webrev.01/
>> Then we hit bug https://bugs.openjdk.org/browse/JDK-8182114 and bandaid it by restoring UseSSE check.
>> That change came before 8296168 which switch off UseAVX if UseSSE < 4:
>> https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/x86/vm_version_x86.cpp#L908
>>
>> This FMA check happens after UseSSE and UseAVX are set. I suggest to remove UseSSE check here instead and keep support_avx().
>
> Saying that. You may remove support_avx() here but you need to add it to assembler vector instructions which have only support_fma() check now.
Thanks for the references! I have reverted this change and will adjust the Graal intrinsic accordingly.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15133#discussion_r1291448160
More information about the graal-dev
mailing list