RFR: 8314078: HotSpotConstantPool.lookupField() asserts due to field changes in ConstantPool.cpp

[Ioi Lam]

On Fri, 11 Aug 2023 12:06:36 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

> Thanks for doing this Ioi.
> 
> In this PR or the follow-up renaming RFE, could you please add a "decoder ring" comment to the javadoc for ConstantPool. An incomplete example:
> 
> ```
>  * The following terminology is used when indexing a constant pool entry:
>  * <ul>
>  * <li>rawIndex - index in the bytecode stream after the opcode (could be rewritten for some bytecodes)</li>
>  * <li>cpi - the class file constant pool index</li>
>  * <li>cpci - a constant pool cache index</li>
>  * </ul>
> ```

Hi Doug, thanks for the review. I added the comments into ConstantPool.java. I omitted cpci as it's not part of the API.

I hope to add more details in the comments when fixing the other incorrectly named variables in [JDK-8314172](https://bugs.openjdk.org/browse/JDK-8314172)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15237#issuecomment-1675311831