RFR: 8313302: Fix formatting errors on Windows [v5]

[Stefan Karlsson]

On Wed, 16 Aug 2023 02:21:51 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Fix several formatting errors on Windows
>
> Julian Waters has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Remove whitespace
>  - Revert changes of INTPTR_FORMAT, minor improvements

Changes requested by stefank (Reviewer).

src/hotspot/os/windows/gc/z/zMapper_windows.cpp line 267:

> 265: 
> 266:   if (!res) {
> 267:     fatal_error("Failed to split placeholder", static_cast<uintptr_t>(addr), size);

Suggestion:

    fatal_error("Failed to split placeholder", untype(addr), size);

src/hotspot/os/windows/gc/z/zPhysicalMemoryBacking_windows.cpp line 202:

> 200:     if (!res) {
> 201:       fatal("Failed to unmap view " PTR_FORMAT " " SIZE_FORMAT "M (%ld)",
> 202:             static_cast<uintptr_t>(addr), size / M, GetLastError());

Suggestion:

            untype(addr), size / M, GetLastError());

src/hotspot/os/windows/gc/z/zPhysicalMemoryBacking_windows.cpp line 242:

> 240: void ZPhysicalMemoryBacking::map(zaddress_unsafe addr, size_t size, zoffset offset) const {
> 241:   assert(is_aligned(untype(offset), ZGranuleSize), "Misaligned: " PTR_FORMAT, untype(offset));
> 242:   assert(is_aligned(untype(addr), ZGranuleSize), "Misaligned: " PTR_FORMAT, static_cast<uintptr_t>(addr));

Suggestion:

  assert(is_aligned(untype(addr), ZGranuleSize), "Misaligned: " PTR_FORMAT, untype(addr));

-------------

PR Review: https://git.openjdk.org/jdk/pull/15063#pullrequestreview-1580009829
PR Review Comment: https://git.openjdk.org/jdk/pull/15063#discussion_r1295515784
PR Review Comment: https://git.openjdk.org/jdk/pull/15063#discussion_r1295516066
PR Review Comment: https://git.openjdk.org/jdk/pull/15063#discussion_r1295516411