RFR: 8314249: Refactor handling of invokedynamic in JVMCI ConstantPool [v2]

[Doug Simon]

On Wed, 16 Aug 2023 19:47:00 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @dougxc comments - fixed typos
>
> src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotConstantPool.java line 588:
> 
>> 586:     @Override
>> 587:     public BootstrapMethodInvocation lookupBootstrapMethodInvocation(int index, int opcode) {
>> 588:         int cpi = opcode == -1 ? index : indyIndexConstantPoolIndex(index, opcode);
> 
> Why would opcode be -1 here?

So that tests such as TestDynamicConstant.java can [iterate through the constant pool, looking for invokedynamic related entries](https://github.com/openjdk/jdk/blob/f143380d013b8c0e5ab7ca0026c34e27e7946f69/test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/TestDynamicConstant.java#L356-L359).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15297#discussion_r1296392827