RFR: 8311661: Resolve duplicate symbol of StringTable::StringTable with JDK static linking [v2]

[Coleen Phillimore]

On Mon, 10 Jul 2023 16:40:06 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:

>> Move StringTable to JavaClassFile namespace.
>
> Jiangli Zhou has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8311661
>  - Move  '} // namespace JavaClassFile' to after '#endif //INCLUDE_CDS_JAVA_HEAP'.
>  - 8311661: Resolve duplicate symbol of StringTable::StringTable with JDK static linking

I think I've changed my mind.  Since static build is a build time issue, then maybe a source solution shouldn't be done for this.

src/hotspot/share/runtime/serviceThread.cpp line 119:

> 117:               (has_dcmd_notification_event = (!UseNotificationThread && DCmdFactory::has_pending_jmx_notification())) |
> 118:               (stringtable_work = JavaClassFile::StringTable::has_work()) |
> 119:               (symboltable_work = SymbolTable::has_work()) |

It does look strange since you'd expect SymbolTable to be in the same namespace.

-------------

Changes requested by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14808#pullrequestreview-1524561569
PR Review Comment: https://git.openjdk.org/jdk/pull/14808#discussion_r1259912370