RFR: 8311661: Resolve duplicate symbol of StringTable::StringTable with JDK static linking [v2]
Ioi Lam
iklam at openjdk.org
Tue Jul 11 21:11:14 UTC 2023
On Tue, 11 Jul 2023 20:41:16 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:
> > Something like this might work. We need to enclose all declarations inside `namespace hotspot {...}`, so all .hpp files need to be touched (which I think is OK).
>
> I just looked briefly. For `.hpp` files alone in `hotspot` dir, we have 2276. Although the number of files is large, I think the actual changes are trivial. Still want to make sure everyone is okay with the changes at this scale.
If adding `using hotspot` in precompiled.hpp works, we can roll this out in stages. At the beginning, we can just put the three problematic classes (`Thread`, `StringTable` and `ProfileData`) in the `hotspot` namespace, so only a few files need to be changed.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14808#issuecomment-1631511102
More information about the graal-dev
mailing list