RFR: 8313302: Fix formatting errors on Windows [v3]

[Thomas Stuefe]

On Fri, 28 Jul 2023 10:38:03 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> 



> Hi Thomas,
> 
> > So the point of this change is to satisfy gcc on Windows? Accomodating a new build platform, making (and keeping!) it warning-free is a considerable effort. Even if you do it, it has a lot of side effects on others: reviewer churn, accidental bugs, makes backports more difficult...
> 
> Not really, I was perfectly capable of solving these issues by silencing the error checker in compilerWarnings_gcc.hpp (see ATTRIBUTE_PRINTF and ATTRIBUTE_SCANF), I decided not to do so since I believed these were reasonable changes as the time to fix the formatting on Windows, I was not aware of the actual scale the finished change would be on. I can retract this change if need be, it's not critical to the Project
> 
> > For smallish things its okay, but if it keeps causing massive changes like this one we should discuss this first. In my eyes, this is similar to adding a new platform, for which the bar is very high (it is technically less complex than a new platform, but OTOH it is also less isolated).
> 
> Where would changes like these be discussed? As far as I know, I'm really the only one working on a Project like this. As a side note, the actual changes to HotSpot to get it compiling on gcc are actually minimal, this is technically not one of those changes, and a good chunk of them have already been integrated into mainline
> 
> Should I take the rest of this to build-dev?
> 

For discussing things that relate to hotspot coding, e.g. INTPTR_FORMAT, hotspot-dev would be better. 

> Thanks for your time, Julian

No problem.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15063#issuecomment-1655623178