RFR: 8313302: Fix formatting errors on Windows [v3]
Kim Barrett
kbarrett at openjdk.org
Sat Jul 29 00:41:02 UTC 2023
On Fri, 28 Jul 2023 10:36:12 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> For this one (and the one below) I couldn't figure out whether the intention was for a 32 or 64 bit number in this case. This would be 64 bit on every platform but on Windows, which is 32 bit, and the code directly below this also faces the same issue too, is this intentional?
>
> long is 32-bit on Linux x86 and arm32 too.
[not a review, just a drive-by comment]
The type `long` really shouldn't be used in shared code. There have been discussions and maybe some efforts
to nuke uses, but having just done the grep, there are still quite a few. The one in question might actually be an
appropriate place to use `uintx`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15063#discussion_r1278191849
More information about the graal-dev
mailing list