RFR: 8318694: [JVMCI] disable can_call_java in most contexts for libjvmci compiler threads [v6]

[David Holmes]

On Mon, 30 Oct 2023 07:58:36 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Doug Simon has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   allow JavaCalls in HotSpotConstantPool.callSystemExit
>
> Can't comment on all the details of the changes, but I don't see anything untoward in general.
> 
> Thanks.

> What do you think @dholmes-ora @vnkozlov ?

Normally we use asserts for things that are absolutely expected to be uncovered during testing - things that are purely internal VM concerns and for which a failure is a VM coding error. So I don't think it is necessary to change these to guarantees provided we have sufficient test coverage. The guarantee may not hurt but the same could be said for many other assertions.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16383#issuecomment-1788288243