RFR: 8318694: [JVMCI] disable can_call_java in most contexts for libjvmci compiler threads [v7]
Daniel D. Daugherty
dcubed at openjdk.org
Tue Nov 7 21:51:09 UTC 2023
On Wed, 1 Nov 2023 13:33:32 GMT, Doug Simon <dnsimon at openjdk.org> wrote:
>> This PR reduces the context in which a libjvmci CompilerThread can make a Java call. By default, a CompileThread for a JVMCI compiler can make Java calls (as jarjvmci only works that way). When libjvmci calls into the VM via a CompilerToVM native method, it enters a scope where Java calls are disabled until either the call returns or a nested scope is entered that re-enables Java calls. The latter is required for the Truffle use case described in [JDK-8318694](https://bugs.openjdk.org/browse/JDK-8318694) as well as for a few other VM entry points where libgraal currently still requires the ability to make Java calls (e.g. to load the Java classes used for boxing primitives). We may be able to eventually eliminate all need for libgraal to make Java calls but this PR is a first step in the right direction.
>
> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
>
> convert assertions about can_call_java to guarantees
I meant does that mean that Graal CI is running its own Graal-Tier[1-N] and it not
running the same Tier[1-8] definitions as the main JDK repo at all?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16383#issuecomment-1800232912
More information about the graal-dev
mailing list