RFR: 8320272: Make method_entry_barrier address shared

Dean Long dlong at openjdk.org
Fri Nov 17 22:11:30 UTC 2023


On Fri, 17 Nov 2023 16:10:25 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> Currently all platforms have declared their own address variable for method_entry_barrier stub. Some have even slightly different name: nmethod_entry_barrier. For Leyden project one address is preferable.
> In aarch64 code changed `movptr` to `lea` instruction to get relocation info as on x86.
> 
> Tested x86 and aarch64, tier1-4, xcomp, stress.  I need help to test on other platforms. Thanks!

This seems fine, but you could explain a little more why this is useful for Leyden?  I would think having StubRoutines::method_entry_barrier() would be enough, and that it could reference the existing platform-specific name, minimizing changes.  I don't understand why the storage needs to be shared in StubRoutines::_method_entry_barrier, for example.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16708#issuecomment-1817176789


More information about the graal-dev mailing list