RFR: 8315954: getArgumentValues002.java fails on Graal [v2]

[Frederic Parain]

On Thu, 14 Sep 2023 11:47:30 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> Doug Simon has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - generalized getLiveObjectLocalsAt to getOopMapAt
>>  - need to zero oop_map_buf
>>  - simplified getLiveObjectLocalsAt and moved it from ResolvedJavaMethod to HotSpotResolvedJavaMethod
>
> src/hotspot/share/interpreter/oopMapCache.cpp line 616:
> 
>> 614:   tmp->fill(method, bci);
>> 615:   if (tmp->has_valid_mask()) {
>> 616:     entry->resource_copy(tmp);
> 
> If `tmp` is invalid (e.g. oop map was requested for invalid BCI), then `resource_copy` crashes the VM in strange ways since it blindly trusts the mask size to be valid.

This is not the only place where `resource_copy()` is called, could you add an assert in `resource_copy()` itself to check that it is never called with an invalid bci/mask_size.
Thank you.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15705#discussion_r1333043061