RFR: 8329750: Change Universe functions to return more specific Klass* types [v2]

[Coleen Phillimore]

On Mon, 8 Apr 2024 13:23:29 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update src/hotspot/share/classfile/systemDictionary.cpp
>>   
>>   Dean's suggestion
>>   
>>   Co-authored-by: Dean Long <17332032+dean-long at users.noreply.github.com>
>
> src/hotspot/share/classfile/systemDictionary.cpp line 372:
> 
>> 370:     TypeArrayKlass* tak = Universe::typeArrayKlass(t);
>> 371:     k = tak->array_klass(ndims, CHECK_NULL);
>> 372:     k = k->array_klass(ndims, CHECK_NULL);
> 
> this looks puzzling.  Why are there two array_klass calls now?  Add short comments to explain.

I sort of see now but am getting squint lines.  It's not important for performance to eliminate a virtual call here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18652#discussion_r1555847832