RFR: 8329628: Additional changes after JDK-8329332 [v2]

[Erik Österlund]

On Mon, 8 Apr 2024 20:33:34 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Additional clean up based on comments (mostly Stefan's) during reviews for [JDK-8329332: Remove CompiledMethod and CodeBlobLayout classes](https://bugs.openjdk.org/browse/JDK-8329332).
>> - Renamed `CompiledMethod_lock` to `NMethod_lock`.  (I decided to not change JVMTI's `CompiledMethod[Load|Unload]` names).
>> - Renamed `NMethodIterator::all_blobs` to `NMethodIterator::all`.
>> - Moved `get_deopt_original_pc()` method from `nmethod` to `frame` class.
>> - Reverted `CodeCache::find_nmethod()` to previous functionality to allow return `nullptr` and be consistent with `find_blob()`.
>> - Cleanup some `(nmethod*)` casts.
>> - Use `for (CodeHeap* heap : *_nmethod_heaps) ` in `CodeCache::nmethod_count()` (it was @stefank suggestion,  I don't know how this C++ magic works). I verified it running with `-XX:+PrintNMethodStatistics`.
>> 
>> Testing tier1-3,xcomp,stress
>
> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Addresse comments

Marked as reviewed by eosterlund (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18665#pullrequestreview-1989387186