RFR: 8329750: Change Universe functions to return more specific Klass* types [v3]

Dean Long dlong at openjdk.org
Wed Apr 10 01:59:10 UTC 2024


On Mon, 8 Apr 2024 13:46:32 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> We have various functions in Universe that returns Klass* where they could be returning TypeArrayKlass* and ObjArrayKlass* instead. If we change these functions we could get rid of some casts in the code. Does this seem like a reasonable change?
>
> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert "Update src/hotspot/share/classfile/systemDictionary.cpp
> "
>   
>   This reverts commit d36f650dc3bf9729cd8bd138d23bef3dfdb8e4d2.

> Thanks for the reviews! Dean, I reverted the suggestion to go with the typed TypeArrayKlass given that it had no visible effects on inlining. If you still want it I can fix it in separate commit. /integrate

If there's no benefit, then it would just be for consistency with the other changes.  It's not a big deal though.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18652#issuecomment-2046318919


More information about the graal-dev mailing list