RFR: 8317368: [JVMCI] SIGSEGV in JVMCIEnv::initialize_installed_code on libgraal [v2]

[Tom Rodriguez]

On Tue, 6 Feb 2024 09:13:10 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> Tom Rodriguez has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>> 
>>  - Merge branch 'master' into tkr-nmethod-keep-alive
>>  - Move BarrierSetNMethod call into JVMCINMethodHandle::set_nmethod
>>  - 8317368: [JVMCI] SIGSEGV in JVMCIEnv::initialize_installed_code on libgraal
>
> src/hotspot/share/jvmci/jvmciEnv.hpp line 391:
> 
>> 389:   CodeBlob* get_code_blob(JVMCIObject code);
>> 390: 
>> 391:   // Given an instance of HotSpotInstalledCode return the corresponding nmethod.
> 
> Can you please improve the comment while here, adding a `,` after `HotSpotInstalledCode`.

ok

> src/hotspot/share/runtime/javaThread.hpp line 384:
> 
>> 382:   oop        _jvmci_reserved_oop0;
>> 383: 
>> 384:   // This field is used to keep an nmethod visible to the GC so that it can be kept alive
> 
> suggestion: `so that it can be kept alive` -> `so that it and its contained oops can be kept alive`

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17714#discussion_r1566294177
PR Review Comment: https://git.openjdk.org/jdk/pull/17714#discussion_r1566295509