RFR: 8337654: Relocate uncommon trap stub from SharedRuntime to OptoRuntime [v3]

[Andrew Dinn]

On Thu, 1 Aug 2024 23:51:55 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Andrew Dinn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add new riscv source
>
> src/hotspot/cpu/aarch64/runtime_aarch64.cpp line 219:
> 
>> 217:   // crud.  We cannot block on this call, no GC can happen.  Call should
>> 218:   // restore return values to their stack-slots with the new SP.
>> 219:   // Thread is in rdi already.
> 
> It's weird to see `rdi` being mentioned in AArch64-specific code :-)

A hangover from the existing (relocated) code going back to when it was cloned from runtime_x86_64.cpp (where the comment still exists even though it appears also to be incorrect!). I'll delete it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20417#discussion_r1704111240