RFR: 8315884: New Object to ObjectMonitor mapping [v16]

[Axel Boldt-Christmas]

On Wed, 14 Aug 2024 05:45:27 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Axel Boldt-Christmas has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Whitespace and nits
>
> src/hotspot/cpu/aarch64/c1_MacroAssembler_aarch64.cpp line 84:
> 
>> 82: 
>> 83:   if (LockingMode == LM_LIGHTWEIGHT) {
>> 84:     lightweight_lock(disp_hdr, obj, hdr, temp, rscratch2, slow_case);
> 
> Given the declaration:
> 
> void MacroAssembler::lightweight_lock(Register basic_lock, Register obj, Register t1, Register t2, Register t3, Label& slow) 
> 
> it looks odd to pass `disp_hdr` here - is that variable just mis-named?

Yeah, because the BasicLock and display header / metadata in BasicLock are all on the same address so they have been used interchangeably in c1,c2 and the interpreter. It should probably be fixed. But maybe in a separate PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20067#discussion_r1716539547