RFR: 8339112: Move JVM Klass flags out of AccessFlags [v2]
Coleen Phillimore
coleenp at openjdk.org
Fri Aug 30 14:00:45 UTC 2024
On Thu, 29 Aug 2024 22:40:43 GMT, Dean Long <dlong at openjdk.org> wrote:
>> src/hotspot/share/oops/klass.hpp line 436:
>>
>>> 434: #endif
>>> 435: static ByteSize bitmap_offset() { return byte_offset_of(Klass, _bitmap); }
>>> 436: static ByteSize misc_flags_offset() { return byte_offset_of(Klass, _misc_flags); }
>>
>> Suggestion:
>>
>> static ByteSize misc_flags_offset() { return byte_offset_of(Klass, _misc_flags._flags); }
>
> We probably shouldn't assume the _flags field starts at offset 0.
Yes, this was wrong. Thanks for seeing this.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20719#discussion_r1738643187
More information about the graal-dev
mailing list